add a query smart contract method #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: [email protected] <[email protected]>
nklincoln
requested review from
aklenik,
feihujiang,
jiangyaoguo,
liam-grace and
panyu4
as code owners
aklenik
requested changes
Sep 9, 2019
There was a problem hiding this comment.
👍 for this!
If the underlying adapter implementation doesn't support the function, then the obj.querySmartContract() call will result in an ugly error. We should handle this more gracefully:
- Either check whether the adapter has this method, and throw on the abstract class level.
- Or add the method implementation to every adapter, and make them throw a "not supported" error.
The second approach would make it clear that the adapter needs some improvement.
aklenik
added
PR/change requested
aklenik
approved these changes
Sep 11, 2019
aklenik
removed
PR/change requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: [email protected] [email protected]
This PR adds the companion method of
invokeSmartContractto expose the ability toquerySmartContractfrom the blockchain object directly, thereby raising the ability to perform the call beyond a Fabric level interaction.This will give Caliper testing the ability to: